Repository navigation
fix(crypto): Copy HMAC bytes into a new std::vector, to avoid a use-after-free - #342
Merged
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
andreiltd
approved these changes
Oct 22, 2026
andreiltd
left a comment
andreiltd
left a comment
Member
There was a problem hiding this comment.
Thanks! One note here: the JS class is storing the key in the slot but it looks like it never release it, so vector is leaking memory.
JS::SetReservedSlot(instance, std::to_underlying(Slots::KeyData), JS::PrivateValue(data.release()->data()));The class should use finalizable policy and drop the vector in finalize method:
class CryptoKey : public BuiltinImpl<CryptoKey, FinalizableClassPolicy>
Member
|
Tracked here: #343 |
devin-ai-integration Bot
added a commit
to draco2003/StarlingMonkey
that referenced
this pull request
Nov 3, 2026
The salt BufferSource was held as a borrowed span until after the iterations and hash members were read. Those reads run user JS (getters, valueOf), which can detach or mutate the backing buffer — e.g. via transfer — leaving the derived bits computed from detached memory, the same class of issue fixed for HMAC key material in bytecodealliance#342. Copy the salt into a std::vector immediately after value_to_buffer, before any further property reads. Adds a regression test whose iterations getter detaches the salt buffer mid-normalization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #341.